Notifications
Clear all

Hard reboot required  

  RSS

Rajnar
(@rajnar)
Member
Joined: 1 year ago
Posts: 9
January 7, 2020 1:31 pm  

John mentioned that some of us found that Unify needed a reboot to finalize installation if some files were out of date. I began with a clean installation and the latest files, and my system still needed to be restarted. Otherwise the latest beta is working perfectly for me (Windows 10 pro/Ryzen). 


Quote
paull
(@paull)
Member
Joined: 11 months ago
Posts: 23
January 7, 2020 1:45 pm  

I've installed Unify on two Win10 1903 machines. Both have required are restart.


ReplyQuote
PlugInGuruForums
(@pluginguruforums)
Owner/Guru Admin
Joined: 1 year ago
Posts: 134
January 8, 2020 1:10 am  

To be clear - we are including the latest version of  Microsoft Visual C++ Redistributable - Unify requires this in order to display and function properly. THAT is what is causing the hard restart of your computer if you were previously using a very old version. I apologize for this happening, but it's not Unify that is doing it - we are working to make sure we alert PC users that this might happen - because it is not cool to do this without even letting you know.

 

My apologies if you lost any work from this happening! Our beta team didn't mention this happening because they were (obviously) all using a new version of Visual C++ or Unify wouldn't have even worked for them.

Life is Sound / Sound is Divine
www.pluginguru.com


mj_prod liked
ReplyQuote
msorrels
(@msorrels)
New Member
Joined: 11 months ago
Posts: 2
January 8, 2020 4:43 pm  

The problem is you are calling the VC Runtime with just the /quiet flag but aren't also including the /norestart flag.  So if the VC runtime is in use and can't be updated, because you didn't prevent the restart and you said quiet mode it reboots (or at least forces the user to log off and kills running apps).

You need to change your installer to not call the VC installer with just the /quiet flag.  Perhaps /install /quiet /norestart would be the better choice.  Then Innosetup will still prompt the user for a restart but won't just do it without asking.

Your Windows setup also really should ask the user for the directory to install the VST2 plugins to and remember the selection (Innosetup can easily do this).  For VST3 plugins there is only one directory that is supposed to be used, so you don't really need to ask for that one. 

I'd recommend getting the User's default VST2 directory by reading the registry key from HKEY_LOCAL_MACHINE\SOFTWARE\VST\VSTPluginsPath.  While not a standard, lots of plugins will read it for the user's choice directory.  (and if it's not there default to %COMMONPROGRAMFILES%\VST2 )  Don't hard code c:\

(For 32bit plugins use HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\VST\VSTPluginsPath and %CommonProgramFiles(x86)%\VST2)

You should also ask for the data directory to use instead of installing in User Public Documents as well (and remember that too for future installs).

When my computer rebooted during the install it forced me to spend a bunch of time taking apart your installer and checking it.  You really should submit any installers you release to www.virustotal.com so they are already scanned (yours wasn't until I submitted it).  It's a really good sanity check.  Otherwise your release may have false positives and will cause you no end of trouble.  And in the 1 in a zillion chance something on your end has gotten infected (this is rare but it can happen) testing your installer before you release it isn't a bad idea.

I'll admit your installer left a very bad taste in my mouth, I'm still angry over it.


RainBro liked
ReplyQuote
getdunne
(@getdunne)
Member Admin
Joined: 1 year ago
Posts: 1607
January 9, 2020 2:50 am  
Posted by: @msorrels

The problem is you are calling the VC Runtime with just the /quiet flag but aren't also including the /norestart flag.  So if the VC runtime is in use and can't be updated, because you didn't prevent the restart and you said quiet mode it reboots (or at least forces the user to log off and kills running apps).

You need to change your installer to not call the VC installer with just the /quiet flag.  Perhaps /install /quiet /norestart would be the better choice.  Then Innosetup will still prompt the user for a restart but won't just do it without asking.

Your Windows setup also really should ask the user for the directory to install the VST2 plugins to and remember the selection (Innosetup can easily do this).  For VST3 plugins there is only one directory that is supposed to be used, so you don't really need to ask for that one. 

I'd recommend getting the User's default VST2 directory by reading the registry key from HKEY_LOCAL_MACHINE\SOFTWARE\VST\VSTPluginsPath.  While not a standard, lots of plugins will read it for the user's choice directory.  (and if it's not there default to %COMMONPROGRAMFILES%\VST2 )  Don't hard code c:\

(For 32bit plugins use HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\VST\VSTPluginsPath and %CommonProgramFiles(x86)%\VST2)

You should also ask for the data directory to use instead of installing in User Public Documents as well (and remember that too for future installs).

When my computer rebooted during the install it forced me to spend a bunch of time taking apart your installer and checking it.  You really should submit any installers you release to www.virustotal.com so they are already scanned (yours wasn't until I submitted it).  It's a really good sanity check.  Otherwise your release may have false positives and will cause you no end of trouble.  And in the 1 in a zillion chance something on your end has gotten infected (this is rare but it can happen) testing your installer before you release it isn't a bad idea.

I'll admit your installer left a very bad taste in my mouth, I'm still angry over it.

Thank you for this very detailed feedback! I'm still new to working with Inno Setup.

There is a newer v1.0.2 installer which at least sets RestartIfNeededByRun=no, but I will look into your other suggestions as well.

It's clear you know far more about Windows installers and Inno Setup than I do. Would you be interested to help us out with improving our installer script?

-shane


mj_prod and RainBro liked
ReplyQuote
mj_prod
(@mj_prod)
Eminent Member
Joined: 11 months ago
Posts: 38
January 9, 2020 10:34 pm  

Posted by: @getdunne

There is a newer v1.0.2 installer

Hello @getdunne and @pluginguruforums!

Thank you for your work.

Two common questions about new versions:

Will there be a (shorter) changelog about bugfixes and features?

Is it recommended to update over an installed version 1.0.1 or do we need to uninstall it first?

Thanks and God bless, Marius


ReplyQuote
transmit
(@transmit)
Member
Joined: 1 year ago
Posts: 68
January 9, 2020 11:38 pm  

The new version Update 1.0.2 overwrites the old version during installation, I have NOT deleted the previous version.

I can only say that everything works fine for me 😀 

System:
WIN 10 Intel Core i7-10700K CPU @ 3.80GHz, 64 GB RAM, SSD 970 EVO Plus 2TB, USB C 3.2 - Studio One 4
Motif XF, Roli Seaboard Rise, QuNexus, MASCHINE JAM, Presonus ATOM, Wavestate, uvm. …


mj_prod liked
ReplyQuote
getdunne
(@getdunne)
Member Admin
Joined: 1 year ago
Posts: 1607
January 9, 2020 11:48 pm  

@mj_prod

When only the last number in the version  changes, e.g. 1.0.1 to 1.0.2, you can be sure it's just bug fixes and under-the-hood tweaks. The middle number usually changes when something is added. The first number would only change if there has been a major change.

It's fine to install new versions directly over the old ones. That wasn't always the case during the beta test period, but the file structure is stable now.

-shane


mj_prod liked
ReplyQuote
mj_prod
(@mj_prod)
Eminent Member
Joined: 11 months ago
Posts: 38
January 10, 2020 8:50 am  

Hello @transmit and @getdunne,

thank you so much for your help regarding updating and for explaining the versioning system.

Thank you, too,@msorrels for pointing Shane into the right direction with the installation routine. Your expertise is highly appreciated so that me as musicians can concentrate on the easier things of life.

Greetings and God bless, Marius


ReplyQuote
msorrels
(@msorrels)
New Member
Joined: 11 months ago
Posts: 2
January 10, 2020 12:40 pm  
Posted by: @getdunne

Thank you for this very detailed feedback! I'm still new to working with Inno Setup.

There is a newer v1.0.2 installer which at least sets RestartIfNeededByRun=no, but I will look into your other suggestions as well.

It's clear you know far more about Windows installers and Inno Setup than I do. Would you be interested to help us out with improving our installer script?

-shane

I suspect you still want the setup to offer the restart if needed by the run.  What you want though is the VC installer to not do the restart, that way your setup offers the dialog and does the restart.  I think just changing the flags on the VC_redist.x64.exe should fix the reboot without asking problem.

I'm not sure I really have a lot of time to go off on yet another side project.  Innosetup is never much fun and I only do it because I have no choice.  Send me some email (I can't seem to send a private message in this forum) maybe we can work something out.

 


mj_prod liked
ReplyQuote
SSquared
(@ssquared)
Member
Joined: 1 year ago
Posts: 89
January 12, 2020 10:53 pm  
Posted by: @getdunne

Thank you for this very detailed feedback! I'm still new to working with Inno Setup.

There is a newer v1.0.2 installer which at least sets RestartIfNeededByRun=no, but I will look into your other suggestions as well.

Hi.  I purchased yesterday after the livestream and installed 1.0.2.  The 1.0.2 installer forced a reboot on me.  Since I had other applications running, Windows first warned me about having other applications waiting to finish.  I was able to cancel and get back to the Installer dialog where I clicked Finish or whatever button it was.  I was surprised it automatically forced me to reboot.  I canceled the reboot because I always like to completely run through an installer process and wanted to be sure there wasn't another 'Next' button that performed a subsequent step.

Typically, pre-requisites are installed prior to installing your own software.  Then, a message at the end will let the user know they need to reboot and are given the option to "Reboot now" or "Finish and manually reboot".  If Inno Setup does the flow for you, and they do it in this order, then I'd just leave it this order.

Not a problem to reboot.  Just surprised me it was auto-forced.

Ableton Live 10, Omnisphere, Native Instruments, Diva, SynthMaster, Alchemy 1.55, Addictive Keys, Unify


ReplyQuote
getdunne
(@getdunne)
Member Admin
Joined: 1 year ago
Posts: 1607
January 12, 2020 10:58 pm  

@ssquared

Thank you! I made a change to the 1.0.2 Windows installer which I thought would fix the auto-reboot, but evidently it hasn't fully fixed it. I'm pretty sure I know what to change next, but it will likely have to wait until after NAMM.

I do appreciate the feedback, and I'm sorry if this caused you any trouble.

-shane


ReplyQuote
SSquared
(@ssquared)
Member
Joined: 1 year ago
Posts: 89
January 12, 2020 11:06 pm  

@getdunne

No problem.  Thanks.  It's minor.  Have a great time at NAMM.

Ableton Live 10, Omnisphere, Native Instruments, Diva, SynthMaster, Alchemy 1.55, Addictive Keys, Unify


ReplyQuote
getdunne
(@getdunne)
Member Admin
Joined: 1 year ago
Posts: 1607
January 21, 2020 7:26 pm  

Just so everyone here knows... @msorrels has followed up with me privately, and has given me tremendous help and advice! Our next Windows installer will be greatly improved, thanks to him!

-shane


mj_prod and SSquared liked
ReplyQuote
Share: