Notifications
Clear all

Macro assignment with embedded patch not saving

9 Posts
2 Users
1 Likes
65 Views
(@craigr68)
Member
Joined: 3 years ago
Posts: 210
Topic starter  

I don't know if this is a possible bug with v1.11.2, me or what.  Since we're not in beta, I wasn't sure what forum to post to.  Please move if necessary.

The Problem:

I have a top level patch with an embedded instance of unify (Screenshot1).  I have some assignments with Macro1.  The third item in the macro list is linked to control Pump House in the embedded unify on layer2.  If I delete that third item (screenshot2), save this patch, and call it up again, the third item is back again (Screenshot3).  This also occurs with Macro2 which has an embedded macro link. 

I checked that the patch is being saved going by the Date Modified in explorer.  I've verified this does not happen with items 1 and 2 in the list - they can be deleted permanently.  I haven't tried any other patches yet.

Later I added Screenshot4 to show the embedded patch.

This topic was modified 1 month ago 3 times by craigr68

   
Quote
(@craigr68)
Member
Joined: 3 years ago
Posts: 210
Topic starter  

I created a more basic bare minimum patch that I've attached.  I cannot get rid of macro1 link to the embedded patch.  Even "Remove Embedded Unify Links (All) won't remove it.  Initialize from the Macro knob will temporarily remove it, but after saving the patch and reloading it, it's back.

This post was modified 1 month ago 3 times by craigr68

   
ReplyQuote
(@getdunne)
Illustrious Member Admin
Joined: 5 years ago
Posts: 4410
 

I'm unable to reproduce this. Here are the steps I followed:

  1. Unzipped your TopLayer.unify patch file to my desktop.
  2. Drag/dropped this file into the Unify 1.11.2 stand-alone app.
  3. Re-saved the patch into one of my test libraries.
  4. Opened the linked-parameters list for the first macro knob at the top level.
  5. Deleted the one parameter link inst/1/plugin/PumpHouse by clicking the "x" button at the far left.
  6. Re-saved the patch by ALT-clicking the Save button.
  7. Clicked INIT to fully clear out the patch, then re-loaded it from the patch browser.
  8. Opened the linked-parameters list for the first macro knob at the top level, to verify that the list is empty.

   
ReplyQuote
(@craigr68)
Member
Joined: 3 years ago
Posts: 210
Topic starter  

The thing you did that I did not was step 7 init.  If I do that step, I get your same result.  But now if I put that macro link back in and do all the steps except step 7, the problem returns.  I don't understand why INIT was necessary.  And I would have thought "Remove Embedded Unify Links (All)" would have worked also.  Anyway, not worth a lot of trouble.  I'm going to get around all this by just pulling the embedded layer into the topmost level.  Generally that's what I normally do anyway to avoid complications like this with embedded layers in my projects.  I do quite a bit of DAW automation with these macro parameters and embedded can get messy.  Thanks.


   
ReplyQuote
(@getdunne)
Illustrious Member Admin
Joined: 5 years ago
Posts: 4410
 

Posted by: @craigr68

If I do that [step 7], I get your same result.  But now if I put that macro link back in and do all the steps except step 7, the problem returns.  I don't understand why INIT was necessary.

I think what's happening is that the original patch gets re-loaded after you save a modified version to a different library. This is something of an "emergent" (i.e., unplanned/unintended) behavior, due to the complexity of keeping the patch browser and the current patch in sync. I agree this isn't ideal, and I'll see if I can fix it.

 


   
ReplyQuote
(@craigr68)
Member
Joined: 3 years ago
Posts: 210
Topic starter  

Here's another patch that is linked to an embedded unify where the macro knob parameters appear to get crossed up.  And those parameters exhibit that same delete problem mentioned above.  I very often assign macros1 thru 4 (or whatever) with 2 linked entries and they are mixLevel and midiEnable which I automate thru a song.  If you look at the first macro which I have labeled Layer1 Vol, you'll see a layer 4 parameter "inst/4/plugin/Macro1" in there.  To me that has no business being there and I doubt I put it there.  If you look at the other macros you'll see other layer4 parameters where they shouldn't be.  The only layer that should have Layer4 parameters is Layer4 macro and its parameters look correct.  It seems patches with embedded links are prone to this.  I'm going to have to go thru all my projects and see where else this is happening.  Zip file below. 

I've been able to get rid of the erroneous link for the first macro knob by doing your init step.  But it doesn't work for the other macros.

This post was modified 4 weeks ago by craigr68

   
ReplyQuote
(@craigr68)
Member
Joined: 3 years ago
Posts: 210
Topic starter  

I discovered that I can permanently delete the erroneous parameter links by simply unchecking "Link all macro knobs" and "Add missing Macro links".  I never paid any attention to those settings before.  I would prefer to manually enter any embedded links anyway.  However, it seems the parameters should still be able to be manually deleted, saved, and have the save be permanent.


   
ReplyQuote
(@getdunne)
Illustrious Member Admin
Joined: 5 years ago
Posts: 4410
 

@craigr68

The inst/4/plugin/Macro1 link almost certainly was created automatically because you had checked the "Link all Macro Knobs" box in Settings. See https://pluginguru.net/unify/manual/doku.php?id=embedded-unify#settings_view for details. I thought this would be un-checked by default, but I just checked and realized it's ON by default. I'll probably fix that in the next version of Unify.

For the most part, these extra macro links are harmless, especially if the target macro-knob itself doesn't have any parameter links.

I'm still having trouble reproducing the problem of macro links reappearing after you delete. I have saved your patch into a library called "Project" on my PC, opened it, opened up the linked-parameters window for each of the macro knobs at the top level, deleted links by clicking the "X", and then ALT-clicked the Save button, and the deleted links are still gone--nothing reappears. (I did NOT INIT and re-open the patch.)


   
ReplyQuote
(@craigr68)
Member
Joined: 3 years ago
Posts: 210
Topic starter  

I think the reason they would reappear after I deleted them was because those options were on and so they'd get reinserted.  Ever since I turned the options off, no problems so far.  I presume they used to be off by default and that's why I didn't see this before.  Only remaining confusion is the way they inserted in strange ways.  For example, where the embedded macro4 (or whatever) parameters would wind up added to the topmost multiple macros - like cross contamination.  And they would be checked on.  Then when playing a song, automation would start switching things unexpectedly.  Anyway, with those options turned off, it seems fine so far.  I think I'll be fine with this.  Thanks for looking into it.

You know what's really funny?  It's because John talked about those parameters in the first of the livestream which made me look at them.  Otherwise, I'd still be scrambling.  Pretty strange coincidence.  

This post was modified 4 weeks ago 3 times by craigr68

   
getdunne reacted
ReplyQuote
Share: